From 9335b636fe943863a6e088c12de8a31fdc90b5ce Mon Sep 17 00:00:00 2001 From: Dave Love Date: Thu, 23 Nov 2000 14:01:34 +0000 Subject: [PATCH] (string-rectangle): Don't test delete-selection-mode. --- lisp/rect.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/rect.el b/lisp/rect.el index 2189bd714b8..302621776c3 100644 --- a/lisp/rect.el +++ b/lisp/rect.el @@ -334,8 +334,13 @@ When called from a program the rectangle's corners are START and END. The left edge of the rectangle specifies the column for insertion. This command does not delete or overwrite any existing text." (interactive "*r\nsString rectangle: ") - (apply-on-rectangle 'string-rectangle-line start end string - (bound-and-true-p 'delete-selection-mode))) + ;; XEmacs tests `pending-delete-mode' here, and replaces the + ;; rectangle if that's on. Using `delete-selection-mode' here would + ;; only be useful if `mark-even-if-inactive' is on since otherwise + ;; we need the mark to be active, given the interactive spec, and + ;; then we'd always delete. Maybe revisit this and consider testing + ;; `mark-even-if-inactive' too? + (apply-on-rectangle 'string-rectangle-line start end string nil)) (defun string-rectangle-line (startcol endcol string delete) (move-to-column-force startcol) -- 2.30.2